-
Notifications
You must be signed in to change notification settings - Fork 3.4k
refactor tutorial structure to page extension #12923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @schultek, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refactors the underlying architecture for how tutorial pages are rendered. By replacing a custom component with a page extension, the system centralizes the logic for structuring tutorial content, making the markdown files cleaner and more focused on content rather than presentation. This change improves maintainability and consistency across all tutorial pages. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request successfully refactors the tutorial structure from using a TutorialLesson custom component to a TutorialStructureExtension page extension. This change moves the logic for structuring tutorial pages into a dedicated extension, which processes the raw markdown content based on delimiters like ---. The TutorialLesson component and its related imports have been removed, and the markdown files have been updated to reflect the new structure by replacing custom tags with markdown dividers. The new extension correctly identifies and processes intro, steps, and trailing content, maintaining the intended layout and functionality of the tutorial pages. The changes align with the goal of cleaner Jaspr code by leveraging page extensions for content processing.
|
Visit the preview URL for this PR (updated for commit d3516c6): https://flutter-docs-prod--pr12923-ew-fwe-cleanup-2-0scopdyq.web.app |
ericwindmill
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, Thank you!
Refactoring to cleaner Jaspr code for #12900